From e7ddae292a0b3b85589e3151fd3ce68bf8398299 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Tue, 17 May 2022 10:49:30 +0200 Subject: [PATCH] ui: datastore selector: move maintenance mode inline with icon else it's a lot of wasted space for the ordinary case, that hasn't permanent maintenance modes activated, and even if, their admins should be used to it, so not the best space/usability ROI there either. Just use the icon as visual clue and add a tooltip for the maintenance mode info. Signed-off-by: Thomas Lamprecht --- www/form/DataStoreSelector.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/www/form/DataStoreSelector.js b/www/form/DataStoreSelector.js index 90f20bee..eae42bef 100644 --- a/www/form/DataStoreSelector.js +++ b/www/form/DataStoreSelector.js @@ -19,7 +19,14 @@ Ext.define('PBS.form.DataStoreSelector', { header: gettext('Datastore'), sortable: true, dataIndex: 'store', - renderer: Ext.String.htmlEncode, + renderer: (v, metaData, rec) => { + let icon = ''; + if (rec.data?.maintenance) { + let tip = Ext.String.htmlEncode(PBS.Utils.renderMaintenance(rec.data?.maintenance)); + icon = ` `; + } + return Ext.String.htmlEncode(v) + icon; + }, flex: 1, }, { @@ -29,15 +36,6 @@ Ext.define('PBS.form.DataStoreSelector', { renderer: Ext.String.htmlEncode, flex: 1, }, - { - header: gettext('Maintenance'), - sortable: true, - dataIndex: 'maintenance', - renderer: (value) => { - return PBS.Utils.renderMaintenance(value); - }, - flex: 1, - } ], }, });