From 63c07d950c6f7d16c551dfd3923a739740a96135 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Mon, 9 Nov 2020 16:01:28 +0100 Subject: [PATCH] ui: TaskSummary: handle less defined parameters of tasks this makes it a little easier to provide good data, without hardcoding all types in the source object Signed-off-by: Dominik Csapak --- www/dashboard/TaskSummary.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js index e4c5378c..169da2d4 100644 --- a/www/dashboard/TaskSummary.js +++ b/www/dashboard/TaskSummary.js @@ -59,7 +59,7 @@ Ext.define('PBS.TaskSummary', { filterParam.store = view.datastore; } - if (record.data[state] === 0) { + if (record.data[state] === 0 || record.data[state] === undefined) { return; } @@ -200,8 +200,8 @@ Ext.define('PBS.TaskSummary', { render_count: function(value, md, record, rowindex, colindex) { let me = this; let view = me.getView(); - let icon = me.render_icon(view.states[colindex], value); - return `${icon} ${value}`; + let icon = me.render_icon(view.states[colindex], value || 0); + return `${icon} ${value || 0}`; }, }, @@ -209,7 +209,17 @@ Ext.define('PBS.TaskSummary', { let me = this; let controller = me.getController(); let data = []; + if (!source) { + source = {}; + } me.types.forEach((type) => { + if (!source[type]) { + source[type] = { + error: 0, + warning: 0, + ok: 0, + }; + } source[type].type = me.titles[type]; data.push(source[type]); });