diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index 9ce096f5..cb748194 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -662,7 +662,7 @@ pub fn verify( _ => bail!("parameters do not specify a backup group or snapshot"), } - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( worker_type, @@ -935,7 +935,7 @@ fn start_garbage_collection( let job = Job::new("garbage_collection", &store) .map_err(|_| format_err!("garbage collection already running"))?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = crate::server::do_garbage_collection_job(job, datastore, &auth_id, None, to_stdout) .map_err(|err| format_err!("unable to start garbage collection job on datastore {} - {}", store, err))?; diff --git a/src/api2/node/apt.rs b/src/api2/node/apt.rs index e6077a8a..20281919 100644 --- a/src/api2/node/apt.rs +++ b/src/api2/node/apt.rs @@ -90,8 +90,8 @@ fn do_apt_update(worker: &WorkerTask, quiet: bool) -> Result<(), Error> { type: bool, description: r#"Send notification mail about new package updates availanle to the email address configured for 'root@pam')."#, - optional: true, default: false, + optional: true, }, quiet: { description: "Only produces output suitable for logging, omitting progress indicators.", @@ -116,7 +116,7 @@ pub fn apt_update_database( ) -> Result { let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; // FIXME: change to non-option in signature and drop below once we have proxmox-api-macro 0.2.3 let quiet = quiet.unwrap_or(API_METHOD_APT_UPDATE_DATABASE_PARAM_DEFAULT_QUIET); let notify = notify.unwrap_or(API_METHOD_APT_UPDATE_DATABASE_PARAM_DEFAULT_NOTIFY); diff --git a/src/api2/node/disks.rs b/src/api2/node/disks.rs index 97e04edd..44554157 100644 --- a/src/api2/node/disks.rs +++ b/src/api2/node/disks.rs @@ -138,7 +138,7 @@ pub fn initialize_disk( rpcenv: &mut dyn RpcEnvironment, ) -> Result { - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs index 32628c4a..c3840526 100644 --- a/src/api2/node/disks/directory.rs +++ b/src/api2/node/disks/directory.rs @@ -132,7 +132,7 @@ pub fn create_datastore_disk( rpcenv: &mut dyn RpcEnvironment, ) -> Result { - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs index ef7b7c67..0f93f110 100644 --- a/src/api2/node/disks/zfs.rs +++ b/src/api2/node/disks/zfs.rs @@ -254,7 +254,7 @@ pub fn create_zpool( rpcenv: &mut dyn RpcEnvironment, ) -> Result { - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; diff --git a/src/api2/tape/backup.rs b/src/api2/tape/backup.rs index 5e05e599..2288a393 100644 --- a/src/api2/tape/backup.rs +++ b/src/api2/tape/backup.rs @@ -87,7 +87,7 @@ pub fn backup( // early check before starting worker check_drive_exists(&drive_config, &pool_config.drive)?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let eject_media = eject_media.unwrap_or(false); let export_media_set = export_media_set.unwrap_or(false); diff --git a/src/api2/tape/drive.rs b/src/api2/tape/drive.rs index 5cf18fe5..48b58251 100644 --- a/src/api2/tape/drive.rs +++ b/src/api2/tape/drive.rs @@ -227,7 +227,7 @@ pub fn erase_media( let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "erase-media", @@ -268,7 +268,7 @@ pub fn rewind( let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "rewind-media", @@ -354,7 +354,7 @@ pub fn label_media( let (config, _digest) = config::drive::config()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "label-media", @@ -590,7 +590,7 @@ pub fn clean_drive( let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "clean-drive", @@ -717,7 +717,7 @@ pub fn update_inventory( let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "inventory-update", @@ -819,7 +819,7 @@ pub fn barcode_label_media( let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "barcode-label-media", @@ -997,7 +997,7 @@ pub fn catalog_media( let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "catalog-media", diff --git a/src/api2/tape/restore.rs b/src/api2/tape/restore.rs index 441cbd1a..36bee0bd 100644 --- a/src/api2/tape/restore.rs +++ b/src/api2/tape/restore.rs @@ -115,7 +115,7 @@ pub fn restore( // early check before starting worker check_drive_exists(&drive_config, &pool_config.drive)?; - let to_stdout = if rpcenv.env_type() == RpcEnvironmentType::CLI { true } else { false }; + let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI; let upid_str = WorkerTask::new_thread( "tape-restore", diff --git a/src/backup/verify.rs b/src/backup/verify.rs index 7ba8d56a..5e4bc7fb 100644 --- a/src/backup/verify.rs +++ b/src/backup/verify.rs @@ -342,7 +342,7 @@ pub fn verify_backup_dir_with_lock( }; if let Some(filter) = filter { - if filter(&manifest) == false { + if !filter(&manifest) { task_log!( worker, "SKIPPED: verify {}:{} (recently verified)", diff --git a/src/tape/pool_writer.rs b/src/tape/pool_writer.rs index b04bfddb..5cb04eb9 100644 --- a/src/tape/pool_writer.rs +++ b/src/tape/pool_writer.rs @@ -303,7 +303,7 @@ impl PoolWriter { status.bytes_written += bytes_written; - let request_sync = if status.bytes_written >= COMMIT_BLOCK_SIZE { true } else { false }; + let request_sync = status.bytes_written >= COMMIT_BLOCK_SIZE; if !done || request_sync { status.commit()?; @@ -361,7 +361,7 @@ impl PoolWriter { (bytes_written as f64)/(1024.0*1024.0*elapsed), )); - let request_sync = if status.bytes_written >= COMMIT_BLOCK_SIZE { true } else { false }; + let request_sync = status.bytes_written >= COMMIT_BLOCK_SIZE; // register chunks in media_catalog status.catalog.start_chunk_archive(content_uuid, current_file_number)?;