From 2419dc0de98fb09515e4c6593ecc4973660f1264 Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Wed, 3 Nov 2021 13:52:13 +0100 Subject: [PATCH] pbs-client: add option to use the new RateLimiter Signed-off-by: Dietmar Maurer --- Cargo.toml | 2 +- pbs-client/Cargo.toml | 2 +- pbs-client/src/http_client.rs | 24 ++++++++++++++++++++++-- pbs-client/src/tools/mod.rs | 23 ++++++++++++++++++++--- 4 files changed, 44 insertions(+), 7 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 0f163d65..b3cac714 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -97,7 +97,7 @@ pathpatterns = "0.1.2" pxar = { version = "0.10.1", features = [ "tokio-io" ] } proxmox = { version = "0.15.0", features = [ "sortable-macro" ] } -proxmox-http = { version = "0.5.0", features = [ "client", "http-helpers", "websocket" ] } +proxmox-http = { version = "0.5.2", features = [ "client", "http-helpers", "websocket" ] } proxmox-io = "1" proxmox-lang = "1" proxmox-router = { version = "1.1", features = [ "cli" ] } diff --git a/pbs-client/Cargo.toml b/pbs-client/Cargo.toml index b6782c4a..c7b4b1c8 100644 --- a/pbs-client/Cargo.toml +++ b/pbs-client/Cargo.toml @@ -30,7 +30,7 @@ xdg = "2.2" pathpatterns = "0.1.2" proxmox = "0.15.0" proxmox-fuse = "0.1.1" -proxmox-http = { version = "0.5.0", features = [ "client", "http-helpers", "websocket" ] } +proxmox-http = { version = "0.5.2", features = [ "client", "http-helpers", "websocket" ] } proxmox-io = { version = "1", features = [ "tokio" ] } proxmox-lang = "1" proxmox-router = { version = "1.1", features = [ "cli" ] } diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs index 73c83f7a..defaef8a 100644 --- a/pbs-client/src/http_client.rs +++ b/pbs-client/src/http_client.rs @@ -20,7 +20,7 @@ use proxmox::{ }; use proxmox_router::HttpError; -use proxmox_http::client::HttpsConnector; +use proxmox_http::client::{HttpsConnector, RateLimiter}; use proxmox_http::uri::build_authority; use pbs_api_types::{Authid, Userid}; @@ -51,6 +51,8 @@ pub struct HttpClientOptions { ticket_cache: bool, fingerprint_cache: bool, verify_cert: bool, + rate_limit: Option, + bucket_size: Option, } impl HttpClientOptions { @@ -109,6 +111,16 @@ impl HttpClientOptions { self.verify_cert = verify_cert; self } + + pub fn rate_limit(mut self, rate_limit: Option) -> Self { + self.rate_limit = rate_limit; + self + } + + pub fn bucket_size(mut self, bucket_size: Option) -> Self { + self.bucket_size = bucket_size; + self + } } impl Default for HttpClientOptions { @@ -121,6 +133,8 @@ impl Default for HttpClientOptions { ticket_cache: false, fingerprint_cache: false, verify_cert: true, + rate_limit: None, + bucket_size: None, } } } @@ -343,7 +357,13 @@ impl HttpClient { httpc.enforce_http(false); // we want https... httpc.set_connect_timeout(Some(std::time::Duration::new(10, 0))); - let https = HttpsConnector::with_connector(httpc, ssl_connector_builder.build(), PROXMOX_BACKUP_TCP_KEEPALIVE_TIME); + let mut https = HttpsConnector::with_connector(httpc, ssl_connector_builder.build(), PROXMOX_BACKUP_TCP_KEEPALIVE_TIME); + + if let Some(rate_limit) = options.rate_limit { + let bucket_size = options.bucket_size.unwrap_or_else(|| rate_limit*3); + https.set_read_limiter(Some(Arc::new(Mutex::new(RateLimiter::new(rate_limit, bucket_size))))); + https.set_write_limiter(Some(Arc::new(Mutex::new(RateLimiter::new(rate_limit, bucket_size))))); + } let client = Client::builder() //.http2_initial_stream_window_size( (1 << 31) - 2) diff --git a/pbs-client/src/tools/mod.rs b/pbs-client/src/tools/mod.rs index a12635cf..539ad662 100644 --- a/pbs-client/src/tools/mod.rs +++ b/pbs-client/src/tools/mod.rs @@ -135,15 +135,32 @@ pub fn extract_repository_from_map(param: &HashMap) -> Option Result { - connect_do(repo.host(), repo.port(), repo.auth_id()) + connect_do(repo.host(), repo.port(), repo.auth_id(), None, None) .map_err(|err| format_err!("error building client for repository {} - {}", repo, err)) } -fn connect_do(server: &str, port: u16, auth_id: &Authid) -> Result { +pub fn connect_rate_limited( + repo: &BackupRepository, + rate: Option, + bucket_size: Option, +) -> Result { + connect_do(repo.host(), repo.port(), repo.auth_id(), rate, bucket_size) + .map_err(|err| format_err!("error building client for repository {} - {}", repo, err)) +} + +fn connect_do( + server: &str, + port: u16, + auth_id: &Authid, + rate_limit: Option, + bucket_size: Option, +) -> Result { let fingerprint = std::env::var(ENV_VAR_PBS_FINGERPRINT).ok(); let password = get_secret_from_env(ENV_VAR_PBS_PASSWORD)?; - let options = HttpClientOptions::new_interactive(password, fingerprint); + let options = HttpClientOptions::new_interactive(password, fingerprint) + .rate_limit(rate_limit) + .bucket_size(bucket_size); HttpClient::new(server, port, auth_id, options) }